Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: openkruise health check npe error #19545 #19660

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

alswl
Copy link
Contributor

@alswl alswl commented Aug 23, 2024

Fixes ISSUE #19545

Reproduce this case in unit test TestLuaHealthScript with commit 9b0e6a4:

2024-09-08T05:53:13.5111087Z time="2024-09-08T05:52:49Z" level=fatal msg="<string>:12: cannot perform sub operation between number and nil\nstack traceback:\n\t<string>:12: in main chunk\n\t[G]: ?"

The obj.spec.updateStrategy.rollingUpdate.partition missing null value check, and the fix is in next commit.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates? No
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
    • except the FOSSA
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

bunnyshell bot commented Aug 23, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Aug 23, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.81%. Comparing base (4736657) to head (f468807).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19660      +/-   ##
==========================================
+ Coverage   55.80%   55.81%   +0.01%     
==========================================
  Files         320      320              
  Lines       44250    44281      +31     
==========================================
+ Hits        24693    24717      +24     
- Misses      16998    17006       +8     
+ Partials     2559     2558       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alswl alswl force-pushed the fix/openkruise-daemonset-lua-nil branch 3 times, most recently from fe51d23 to 1397483 Compare September 7, 2024 15:46
@alswl alswl changed the title fix: openkruise health check npe error fix: openkruise health check npe error #19545 Sep 8, 2024
Signed-off-by: Jingchao <alswlx@gmail.com>
@alswl alswl force-pushed the fix/openkruise-daemonset-lua-nil branch from 45dad30 to 9b0e6a4 Compare September 8, 2024 05:44
Signed-off-by: Jingchao <alswlx@gmail.com>
@alswl alswl marked this pull request as ready for review September 8, 2024 08:02
@alswl alswl requested a review from a team as a code owner September 8, 2024 08:02
@alswl
Copy link
Contributor Author

alswl commented Sep 8, 2024

@christianh814 please review this pull-request.

@alexmt alexmt merged commit f980187 into argoproj:master Sep 11, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants