-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: openkruise health check npe error #19545 #19660
Merged
alexmt
merged 2 commits into
argoproj:master
from
alswl:fix/openkruise-daemonset-lua-nil
Sep 11, 2024
Merged
fix: openkruise health check npe error #19545 #19660
alexmt
merged 2 commits into
argoproj:master
from
alswl:fix/openkruise-daemonset-lua-nil
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19660 +/- ##
==========================================
+ Coverage 55.80% 55.81% +0.01%
==========================================
Files 320 320
Lines 44250 44281 +31
==========================================
+ Hits 24693 24717 +24
- Misses 16998 17006 +8
+ Partials 2559 2558 -1 ☔ View full report in Codecov by Sentry. |
alswl
force-pushed
the
fix/openkruise-daemonset-lua-nil
branch
3 times, most recently
from
September 7, 2024 15:46
fe51d23
to
1397483
Compare
alswl
changed the title
fix: openkruise health check npe error
fix: openkruise health check npe error #19545
Sep 8, 2024
Signed-off-by: Jingchao <alswlx@gmail.com>
alswl
force-pushed
the
fix/openkruise-daemonset-lua-nil
branch
from
September 8, 2024 05:44
45dad30
to
9b0e6a4
Compare
Signed-off-by: Jingchao <alswlx@gmail.com>
@christianh814 please review this pull-request. |
christianh814
approved these changes
Sep 8, 2024
wanghong230
approved these changes
Sep 11, 2024
alexmt
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ISSUE #19545
Reproduce this case in unit test
TestLuaHealthScript
with commit 9b0e6a4:The
obj.spec.updateStrategy.rollingUpdate.partition
missing null value check, and the fix is in next commit.Checklist: