Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 19373 clipboard copy duration issue #19662

Conversation

olivia-zh-xm
Copy link
Contributor

@olivia-zh-xm olivia-zh-xm commented Aug 23, 2024

Fix: #19373

set hideOnClick for false to prevent hide on click event, and extend duration a bit longer

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Zhao, Olivia <xueming.zhao@fmr.com>
@olivia-zh-xm olivia-zh-xm requested a review from a team as a code owner August 23, 2024 10:38
Copy link

bunnyshell bot commented Aug 23, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Aug 23, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@olivia-zh-xm olivia-zh-xm changed the title fix clipboard copy duration issue fix: clipboard copy duration issue Aug 26, 2024
@olivia-zh-xm olivia-zh-xm changed the title fix: clipboard copy duration issue fix: 19373 clipboard copy duration issue Aug 26, 2024
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy merge 🔥

@todaywasawesome todaywasawesome merged commit f597912 into argoproj:master Aug 28, 2024
30 of 32 checks passed
ashutosh16 pushed a commit that referenced this pull request Aug 28, 2024
Signed-off-by: Zhao, Olivia <xueming.zhao@fmr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Duration of Tooltip for Clipboard Copy Action
3 participants