Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sourceNamespace): Regex Support (#19016) (cherry-pick #19017) #19664

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked feat(sourceNamespace): Regex Support (#19016) (#19017)

  • feat(sourceNamespace): Regex Support

Signed-off-by: Arthur arthur@arthurvardevanyan.com

  • feat(sourceNamespace): Separate exactMatch into patternMatch

Signed-off-by: Arthur arthur@arthurvardevanyan.com


Signed-off-by: Arthur arthur@arthurvardevanyan.com

* feat(sourceNamespace): Regex Support

Signed-off-by: Arthur <arthur@arthurvardevanyan.com>

* feat(sourceNamespace): Separate exactMatch into patternMatch

Signed-off-by: Arthur <arthur@arthurvardevanyan.com>

---------

Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot requested review from a team as code owners August 23, 2024 11:58
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 50.34%. Comparing base (560953c) to head (e667b7b).
Report is 1 commits behind head on release-2.12.

Files Patch % Lines
util/regex/regex.go 40.00% 4 Missing and 2 partials ⚠️
notification_controller/controller/controller.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.12   #19664      +/-   ##
================================================
- Coverage         50.35%   50.34%   -0.01%     
================================================
  Files               312      313       +1     
  Lines             43137    43151      +14     
================================================
+ Hits              21720    21726       +6     
- Misses            18936    18938       +2     
- Partials           2481     2487       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jannfis jannfis merged commit 343dec0 into release-2.12 Aug 23, 2024
22 of 26 checks passed
@jannfis jannfis deleted the cherry-pick-de3bf5-release-2.12 branch August 23, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants