Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typo in ingress section of operator manual #19946

Merged
merged 1 commit into from
Sep 16, 2024
Merged

docs: fix typo in ingress section of operator manual #19946

merged 1 commit into from
Sep 16, 2024

Conversation

kswadi
Copy link
Contributor

@kswadi kswadi commented Sep 16, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@kswadi
docs: fix typo in ingress section of operator manual
64f7539 
Signed-off-by: kswadi <kswadi01@gmail.com>
@kswadi kswadi requested review from a team as code owners September 16, 2024 08:44
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 16, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 16, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@kswadi
Copy link
Contributor Author

kswadi commented Sep 16, 2024

fixed typo in docs: achive -> achieve

@kswadi kswadi mentioned this pull request Sep 16, 2024
Closed
14 tasks
anandf
anandf approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@anandf anandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blakepettersson blakepettersson merged commit 038a832 into argoproj:master Sep 16, 2024
23 of 24 checks passed
christianh814
christianh814 reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@christianh814 christianh814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianh814 christianh814 christianh814 left review comments

@blakepettersson blakepettersson blakepettersson approved these changes

@anandf anandf anandf approved these changes

@nitishfy nitishfy nitishfy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kswadi @blakepettersson @anandf @christianh814 @nitishfy