Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump gitops-engine for performance improvement #19954

Merged

Conversation

crenshaw-dev
Copy link
Member

@crenshaw-dev crenshaw-dev commented Sep 16, 2024

Include this improvement: #19953

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Copy link

bunnyshell bot commented Sep 16, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Sep 16, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.82%. Comparing base (fcc186b) to head (169faa0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19954      +/-   ##
==========================================
- Coverage   55.83%   55.82%   -0.02%     
==========================================
  Files         320      320              
  Lines       44393    44393              
==========================================
- Hits        24786    24781       -5     
  Misses      17048    17048              
- Partials     2559     2564       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nitishfy
Copy link
Contributor

can we close this PR now?

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…arshal

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev marked this pull request as ready for review September 17, 2024 17:21
@crenshaw-dev crenshaw-dev requested a review from a team as a code owner September 17, 2024 17:21
@crenshaw-dev
Copy link
Member Author

@nitishfy no need to close, this should actually be merged.

@ishitasequeira ishitasequeira merged commit ae028c2 into argoproj:master Sep 18, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants