feat: exclude Endpoints and EndpointSlices Kubernetes resource by default #20251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault Signed-off-by: jaehanbyun <awbrg789@naver.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: 변재한 <awbrg789@naver.com>
|
@ishitasequeira I've resolved the conflicts. Thank you! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20251 +/- ##
=======================================
Coverage 55.95% 55.95%
=======================================
Files 322 322
Lines 44673 44673
=======================================
Hits 24996 24996
- Misses 17084 17087 +3
+ Partials 2593 2590 -3 ☔ View full report in Codecov by Sentry. |
nitishfy
approved these changes
Oct 8, 2024
gdsoumya
approved these changes
Oct 8, 2024
|
I think this should be reverted. The behavior of this pull request is not configurable by the users and a user that wants to display Endpoint or Endpoint Slices in the UI of Argo cannot do it anymore. The proposal on the issue suggested to add it to the default configuration for the 3.0 version. |
|
@agaudreault if you open the revert PR, I'll merge |
ALIHAMZA99
pushed a commit
to ALIHAMZA99/argo-cd
that referenced
this pull request
Oct 10, 2024
…ault (argoproj#20251) Signed-off-by: jaehanbyun <awbrg789@naver.com> Signed-off-by: alnoor <alihamzanoor99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20013
Checklist:
What I have done: