Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replacing custom map util functions with golang std functions #20311

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

DaanV2
Copy link
Contributor

@DaanV2 DaanV2 commented Oct 9, 2024

Golang's standard library is growing with their own functions, which means we can start replacing them golangs functions.

NOTE: before removing the functions I use the removed unit tests, to test if golangs own function match the expected behavior.

Checklist:

  • (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Copy link

bunnyshell bot commented Oct 9, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@DaanV2 DaanV2 changed the title Replacing custom map util functions with golang std functions chore:replacing custom map util functions with golang std functions Oct 9, 2024
Signed-off-by: Daan Verstraten <daanverstraten@hotmail.com>
@DaanV2 DaanV2 marked this pull request as ready for review October 9, 2024 13:04
@DaanV2 DaanV2 requested a review from a team as a code owner October 9, 2024 13:04
@DaanV2 DaanV2 changed the title chore:replacing custom map util functions with golang std functions chore: Replacing custom map util functions with golang std functions Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.95%. Comparing base (cfa1c89) to head (afded8c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apis/application/v1alpha1/types.go 0.00% 2 Missing ⚠️
server/application/application.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20311   +/-   ##
=======================================
  Coverage   55.95%   55.95%           
=======================================
  Files         322      322           
  Lines       44714    44704   -10     
=======================================
- Hits        25021    25016    -5     
+ Misses      17101    17100    -1     
+ Partials     2592     2588    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@crenshaw-dev crenshaw-dev merged commit e1472f3 into argoproj:master Oct 9, 2024
28 checks passed
ALIHAMZA99 pushed a commit to ALIHAMZA99/argo-cd that referenced this pull request Oct 10, 2024
…20311)

Signed-off-by: Daan Verstraten <daanverstraten@hotmail.com>
Signed-off-by: alnoor <alihamzanoor99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants