Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: feat: exclude Endpoints and EndpointSlices Kubernetes resource by default #20334

Merged
merged 1 commit into from
Oct 10, 2024
Merged

revert: feat: exclude Endpoints and EndpointSlices Kubernetes resource by default #20334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/operator-manual/declarative-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,7 +1048,7 @@ stringData:

## Resource Exclusion/Inclusion

Resources can be excluded from discovery and sync so that Argo CD is unaware of them. For example, the apiGroup/kind `events.k8s.io/*`, `metrics.k8s.io/*`, `coordination.k8s.io/Lease`, `""/Endpoints` and `discovery.k8s.io/EndpointSlice` are always excluded. Use cases:
Resources can be excluded from discovery and sync so that Argo CD is unaware of them. For example, the apiGroup/kind `events.k8s.io/*`, `metrics.k8s.io/*` and `coordination.k8s.io/Lease` are always excluded. Use cases:

* You have temporal issues and you want to exclude problematic resources.
* There are many of a kind of resources that impacts Argo CD's performance.
Expand Down
2 changes: 0 additions & 2 deletions util/settings/resources_filter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ var coreExcludedResources = []FilteredResource{
{APIGroups: []string{"events.k8s.io", "metrics.k8s.io"}},
{APIGroups: []string{""}, Kinds: []string{"Event"}},
{APIGroups: []string{"coordination.k8s.io"}, Kinds: []string{"Lease"}},
{APIGroups: []string{""}, Kinds: []string{"Endpoints"}},
{APIGroups: []string{"discovery.k8s.io"}, Kinds: []string{"EndpointSlice"}},
}

type ResourcesFilter struct {
Expand Down
Loading