feat(appset): add 'project' to the Cluster Generator params

[CefBoud]

Closes #18814

Description

This PR adds the project parameter to the Cluster generator. If the cluster doesn't have a project field within its Secret, the param's value defaults to default.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.00%. Comparing base (29c59ab) to head (8a6e31d).
Report is 7 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #20338      +/-   ##
==========================================
+ Coverage   55.96%   56.00%   +0.03%     
==========================================
  Files         322      322              
  Lines       44717    44723       +6     
==========================================
+ Hits        25025    25046      +21     
+ Misses      17095    17083      -12     
+ Partials     2597     2594       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[crenshaw-dev]

I like the idea, but I think we should default to an empty string or nil instead of default.

Clusters can be either project-scoped or unscoped. If the project field isn't populated, it's unscoped. project: default to me implies "scoped to the default project".

[CefBoud]

@crenshaw-dev Thanks for your review.

My concern with setting the project to nil or an empty string is that for applications generated from unscoped clusters, using project: '{{.project}}' would fail validation. The reason is that the value must correspond to an existing project. If the intended behavior is that an application’s project matches the cluster’s project, one could argue that it should default to the default project for unscoped clusters, as that would be the only valid option.

If the validation failure is acceptable, I am happy to make the change.

[crenshaw-dev]

I think if the user's intent is to use the default project for unscoped clusters, they could use project: '{{ default "default" .project }}'. If their intent is to exclude unscoped clusters, I think it would be possible to use a matchExpressions post selector to exclude them. Probably would be a good idea to validate.

[CefBoud]

@crenshaw-dev Thank you for the explanation. It makes perfect sense. I made the changes.

[crenshaw-dev]

Thanks!