Add new dependency to CONTRIBUTING.md #38

merenbach · 2018-03-16T01:06:26Z

Problem

When running make codegen, which in turn invokes the equivalent of make protogen and then make clientgen, the binary protoc-gen-go is invoked during the protogen build phase—and is not installed through brew install protobuf.

Solution

Rectify by adding go get -u github.com/golang/protobuf/protoc-gen-go to CONTRIBUTING.md, per the protobuf installation steps.

alexmt

👍

Label apps with overrides

…luster k8s dashboard feature in AKP (argoproj#48) * feat: send data to agent Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * (wip)feat: send data to syncer APIs * add support for columns info * fix: resource deletion missing events * feat: use resource sync and health info * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: enable dashboard feature by using env var * fix: 1.21.0 -> 1.21 * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Rafal <rafpelczar@gmail.com>

Add new dependency to CONTRIBUTING.md

d90d855

merenbach requested a review from alexmt March 16, 2018 01:06

alexmt approved these changes Mar 16, 2018

View reviewed changes

alexmt merged commit 3927cc0 into argoproj:master Mar 16, 2018

merenbach deleted the add-protoc-gen-go branch March 16, 2018 17:38

alexec pushed a commit that referenced this pull request Apr 24, 2019

Merge pull request #38 from merenbach/503-indicate-overrides

9e45d5c

Label apps with overrides

alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Oct 4, 2023

fix(ui): ui should show the same page number as in API (argoproj#38)

dff4161

alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Jan 19, 2024

fix(ui): ui should show the same page number as in API (argoproj#38)

edb3c2b

alexmt pushed a commit to alexmt/argo-cd that referenced this pull request May 20, 2024

fix(ui): ui should show the same page number as in API (argoproj#38)

7cf6916

alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Sep 12, 2024

fix(ui): ui should show the same page number as in API (argoproj#38)

79a6630

alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Oct 28, 2024

fix(ui): ui should show the same page number as in API (argoproj#38)

c1cd823

gdsoumya pushed a commit to gdsoumya/argo-cd that referenced this pull request Nov 8, 2024

fix(ui): ui should show the same page number as in API (argoproj#38)

99ba024

alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Dec 6, 2024

fix(ui): ui should show the same page number as in API (argoproj#38)

0a8d5e3

alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Dec 16, 2024

fix(ui): ui should show the same page number as in API (argoproj#38)

85838bd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new dependency to CONTRIBUTING.md #38

Add new dependency to CONTRIBUTING.md #38

merenbach commented Mar 16, 2018

alexmt left a comment

Add new dependency to CONTRIBUTING.md #38

Add new dependency to CONTRIBUTING.md #38

Conversation

merenbach commented Mar 16, 2018

Problem

Solution

alexmt left a comment

Choose a reason for hiding this comment