-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto create namespace #3976
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3976 +/- ##
==========================================
+ Coverage 42.11% 42.12% +0.01%
==========================================
Files 123 123
Lines 18127 18132 +5
==========================================
+ Hits 7634 7639 +5
Misses 9514 9514
Partials 979 979
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you please include fix in the engine related to namespace creation in the same PR? Just in case someone uses master and decided to try that feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixed #1809 |
* feat: auto create namespace * feat: fixing yarn lint error. * feat: fixing yarn lint error. * update to the latest gitops-engine * fix tidiness of go.sum
* feat: auto create namespace * feat: fixing yarn lint error. * feat: fixing yarn lint error. * update to the latest gitops-engine * fix tidiness of go.sum
I think this feature is great. One thing is Namespace annotations, for istio-injection for example. That is where I see this feature getting to be a bunch of work or not as useful as it seems to be. |
Checklist: