Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto create namespace #3976

Merged
merged 7 commits into from
Jul 27, 2020
Merged

Conversation

mayzhang2000
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2020

Codecov Report

Merging #3976 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3976      +/-   ##
==========================================
+ Coverage   42.11%   42.12%   +0.01%     
==========================================
  Files         123      123              
  Lines       18127    18132       +5     
==========================================
+ Hits         7634     7639       +5     
  Misses       9514     9514              
  Partials      979      979              
Impacted Files Coverage Δ
controller/cache/cache.go 0.00% <0.00%> (ø)
controller/sync.go 40.56% <ø> (ø)
controller/appcontroller.go 45.54% <100.00%> (ø)
util/helm/client.go 59.05% <0.00%> (+1.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 275daa7...bcb9386. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please include fix in the engine related to namespace creation in the same PR? Just in case someone uses master and decided to try that feature.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayzhang2000 mayzhang2000 merged commit 067dcce into argoproj:master Jul 27, 2020
@mayzhang2000
Copy link
Contributor Author

fixed #1809

rachelwang20 pushed a commit to rachelwang20/argo-cd that referenced this pull request Aug 5, 2020
* feat: auto create namespace

* feat: fixing yarn lint error.

* feat: fixing yarn lint error.

* update to the latest gitops-engine

* fix tidiness of go.sum
skibum55 pushed a commit to skibum55/argo-cd that referenced this pull request Aug 10, 2020
* feat: auto create namespace

* feat: fixing yarn lint error.

* feat: fixing yarn lint error.

* update to the latest gitops-engine

* fix tidiness of go.sum
@konokimo
Copy link

konokimo commented Dec 3, 2020

I think this feature is great. One thing is Namespace annotations, for istio-injection for example. That is where I see this feature getting to be a bunch of work or not as useful as it seems to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants