Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): widgets don't have tooltips (#4257) #4261

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

jsoref
Copy link
Member

@jsoref jsoref commented Sep 4, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

closes #4257

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in application-details.tsx and account-details.tsx looks good.

However certs-list.tsx, gpgkeys-list.tsx and projects-list.tsx are trying to use non-exisintg title property of actionMenu. Can you please revert changes in these files?

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

Codecov Report

Merging #4261 into master will decrease coverage by 1.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4261      +/-   ##
==========================================
- Coverage   42.85%   41.18%   -1.67%     
==========================================
  Files         124      122       -2     
  Lines       18408    16584    -1824     
==========================================
- Hits         7888     6830    -1058     
+ Misses       9501     8772     -729     
+ Partials     1019      982      -37     
Impacted Files Coverage Δ
server/application/broadcaster.go 66.66% <0.00%> (-24.25%) ⬇️
util/cache/redis.go 45.94% <0.00%> (-10.06%) ⬇️
util/argo/normalizers/knowntypes_normalizer.go 57.57% <0.00%> (-6.18%) ⬇️
util/db/db.go 63.63% <0.00%> (-5.60%) ⬇️
util/helm/cmd.go 39.13% <0.00%> (-5.57%) ⬇️
util/helm/index.go 75.00% <0.00%> (-5.00%) ⬇️
util/kustomize/kustomize.go 66.01% <0.00%> (-4.82%) ⬇️
util/ksonnet/ksonnet.go 40.00% <0.00%> (-4.45%) ⬇️
controller/sync.go 70.37% <0.00%> (-4.16%) ⬇️
util/jwt/jwt.go 54.00% <0.00%> (-4.07%) ⬇️
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae5f93...f2b8ba0. Read the comment docs.

@alexmt alexmt merged commit 3f7d600 into argoproj:master Sep 24, 2020
@jsoref jsoref deleted the issue-4257 branch September 24, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filters/similar widgets near login/logout don't have tooltips
3 participants