Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change button type to allow helm values file to be specified in New App (#4576) #4635

Merged
merged 1 commit into from
Oct 30, 2020
Merged

fix: change button type to allow helm values file to be specified in New App (#4576) #4635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ui/src/app/applications/components/application-create-panel/application-create-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,19 @@ export const ApplicationCreatePanel = (props: {
const generalPanel = () => (
<div className='white-box'>
<p>GENERAL</p>
{/*
Need to specify "type='button'" because the default type 'submit'
will activate yaml mode whenever enter is pressed while in the panel.
This causes problems with some entry fields that require enter to be
pressed for the value to be accepted.

See https://github.com/argoproj/argo-cd/issues/4576
*/}
{!yamlMode && (
<button className='argo-button argo-button--base application-create-panel__yaml-button' onClick={() => setYamlMode(true)}>
<button
type='button'
className='argo-button argo-button--base application-create-panel__yaml-button'
onClick={() => setYamlMode(true)}>
Edit as YAML
</button>
)}
Expand Down