Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for --kustomize-force-common-label CLI flag #4650

Conversation

oboukili
Copy link
Contributor

@oboukili oboukili commented Oct 23, 2020

Closes #4649

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

@oboukili oboukili changed the title Support for --kustomize-force-common-label CLI flag #4649 Support for --kustomize-force-common-label CLI flag Oct 23, 2020
@codecov-io
Copy link

codecov-io commented Oct 23, 2020

Codecov Report

Merging #4650 into master will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4650      +/-   ##
==========================================
+ Coverage   41.10%   41.12%   +0.02%     
==========================================
  Files         127      127              
  Lines       17367    17373       +6     
==========================================
+ Hits         7139     7145       +6     
- Misses       9202     9203       +1     
+ Partials     1026     1025       -1     
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/types.go 57.92% <ø> (ø)
cmd/argocd/commands/app.go 6.20% <50.00%> (+0.11%) ⬆️
util/kustomize/kustomize.go 64.65% <100.00%> (+2.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd856e1...cbb48f7. Read the comment docs.

@oboukili oboukili force-pushed the 4649-support-kustomize-force-common-label branch 2 times, most recently from 5eb40ec to 815553f Compare October 23, 2020 16:48
@oboukili
Copy link
Contributor Author

I would gladly appreciate some help regarding make codegen not working on my workstation.

@oboukili
Copy link
Contributor Author

I added the (hopefully) relevant make codegen logs in this gist, thanks for your help!

@oboukili oboukili force-pushed the 4649-support-kustomize-force-common-label branch from 815553f to 1854d05 Compare October 26, 2020 13:20
@oboukili oboukili marked this pull request as ready for review October 26, 2020 13:32
@oboukili oboukili requested a review from jannfis October 26, 2020 15:15
@oboukili oboukili force-pushed the 4649-support-kustomize-force-common-label branch from 1854d05 to cbb48f7 Compare October 28, 2020 07:03
@jannfis
Copy link
Member

jannfis commented Nov 3, 2020

Hey @oboukili, apologies for the delay. I wanted to merge #4613 before coming back to this one.

Can you please rebase your branch and adapt to the changes made in #4613? Maybe also incorporate force flag for the common annotations introduced in #4613?

@josiah-wolf-oberholtzer
Copy link
Contributor

Any chance of this being revisited?

@alexmt
Copy link
Collaborator

alexmt commented Jun 9, 2021

Closing since #6443 implemented the same changes

@alexmt alexmt closed this Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Kustomize commonLabels --force option
5 participants