Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve fetching commit SHAs #5312

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jan 26, 2021

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

  • Followup for feat: support fetch refs (#1604) #4893 . Some git providers e.g. Bitbucket don't support git fetch origin <revision> if revision is a commit sha.
  • The git fetch origin <revision> should fetch be executed with --force and --tags to support force pushes and load commit metadata

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt requested a review from jannfis January 26, 2021 00:10
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit d8b545d into argoproj:master Jan 26, 2021
@alexmt alexmt deleted the 4893-git-fetch-fix branch January 26, 2021 07:13
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Jan 26, 2021
Signed-off-by: Alexander Matyushentsev <Alexander_Matyushentsev@intuit.com>
alexmt pushed a commit that referenced this pull request Jan 26, 2021
Signed-off-by: Alexander Matyushentsev <Alexander_Matyushentsev@intuit.com>
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
Signed-off-by: Alexander Matyushentsev <Alexander_Matyushentsev@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants