Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support longer http cookie (#2917) #5497

Merged
merged 3 commits into from
Feb 18, 2021

Conversation

kshamajain99
Copy link
Contributor

@kshamajain99 kshamajain99 commented Feb 11, 2021

Signed-off-by: kshamajain99 kshamajain99@gmail.com

closes #2917

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).

@kshamajain99 kshamajain99 force-pushed the http-cookie branch 3 times, most recently from c116cef to f4af456 Compare February 11, 2021 20:46
@codecov-io
Copy link

Codecov Report

Merging #5497 (f4af456) into master (c936355) will decrease coverage by 0.09%.
The diff coverage is 80.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5497      +/-   ##
==========================================
- Coverage   40.94%   40.84%   -0.10%     
==========================================
  Files         137      143       +6     
  Lines       18611    18911     +300     
==========================================
+ Hits         7621     7725     +104     
- Misses       9903    10096     +193     
- Partials     1087     1090       +3     
Impacted Files Coverage Δ
util/oidc/oidc.go 18.66% <0.00%> (ø)
util/http/http.go 55.81% <80.00%> (+17.71%) ⬆️
server/logout/logout.go 81.25% <85.71%> (-1.25%) ⬇️
server/server.go 54.49% <100.00%> (-0.26%) ⬇️
util/argo/argo.go 59.09% <0.00%> (-0.39%) ⬇️
controller/appcontroller.go 53.55% <0.00%> (-0.02%) ⬇️
cmd/argocd/commands/app.go 0.00% <0.00%> (ø)
server/session/ratelimiter.go 100.00% <0.00%> (ø)
pkg/apis/application/v1alpha1/register.go 0.00% <0.00%> (ø)
util/grpc/json.go 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c936355...f4af456. Read the comment docs.

util/http/http.go Show resolved Hide resolved
util/http/http.go Outdated Show resolved Hide resolved
util/http/http.go Show resolved Hide resolved
server/server.go Outdated Show resolved Hide resolved
server/logout/logout.go Outdated Show resolved Hide resolved
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
@kshamajain99 kshamajain99 force-pushed the http-cookie branch 2 times, most recently from 69692b8 to 87f41ee Compare February 17, 2021 17:58
server/server.go Outdated Show resolved Hide resolved
server/server.go Outdated Show resolved Hide resolved
util/http/http.go Outdated Show resolved Hide resolved
…d.token

Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you @kshamajain99 !

@alexmt alexmt merged commit 6de3cf4 into argoproj:master Feb 18, 2021
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
* fix: support longer cookie

Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"illegal base64 data at input byte 2174" when working with Dex Ldap connector when groupSearch is enabled
3 participants