Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add health-checks for Elasticsearch #6052 #6052

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Conversation

pupseba
Copy link
Contributor

@pupseba pupseba commented Apr 17, 2021

Add health-checks for Elasticsearch operated resources.

It considers both "phase" and "health" as provided by the Elasticsearch object itself.
https://github.com/elastic/cloud-on-k8s/blob/6bb3dc7f6c0d8753a30f87ce69b7de8f0d9e0f35/pkg/apis/elasticsearch/v1/elasticsearch_types.go#L347

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

pupseba added 3 commits April 17, 2021 16:32
Signed-off-by: Sebastian Greco <pup_seba@yahoo.com>
Signed-off-by: Sebastian Greco <pup_seba@yahoo.com>
Signed-off-by: Sebastian Greco <pup_seba@yahoo.com>
@pupseba pupseba changed the title feat: Add health-checks for Elasticsearch feat: Add health-checks for Elasticsearch #6052 Apr 17, 2021
@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #6052 (a35d1ea) into master (6fb395f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6052   +/-   ##
=======================================
  Coverage   40.97%   40.97%           
=======================================
  Files         147      147           
  Lines       19691    19691           
=======================================
  Hits         8069     8069           
  Misses      10518    10518           
  Partials     1104     1104           
Impacted Files Coverage Δ
util/settings/settings.go 41.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb395f...a35d1ea. Read the comment docs.

@pupseba pupseba marked this pull request as ready for review April 17, 2021 15:41
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you!

@alexmt alexmt merged commit 5ca0948 into argoproj:master Apr 20, 2021
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification PR requires pre-release verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants