Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add https prefix to ingress URLs if hosts field is present #6901

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Aug 3, 2021

Fixes #6884

Signed-off-by: Remington Breeze remington@breeze.software

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Remington Breeze <remington@breeze.software>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

controller/cache/info.go Outdated Show resolved Hide resolved
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt August 3, 2021 22:31
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #6901 (5862535) into master (d404f0e) will decrease coverage by 0.00%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6901      +/-   ##
==========================================
- Coverage   41.08%   41.08%   -0.01%     
==========================================
  Files         157      157              
  Lines       20978    20990      +12     
==========================================
+ Hits         8619     8623       +4     
- Misses      11133    11139       +6     
- Partials     1226     1228       +2     
Impacted Files Coverage Δ
controller/cache/info.go 63.50% <16.66%> (-1.38%) ⬇️
controller/appcontroller.go 52.95% <0.00%> (-0.42%) ⬇️
util/settings/settings.go 47.77% <0.00%> (ø)
pkg/apis/application/v1alpha1/types.go 57.87% <0.00%> (+0.15%) ⬆️
server/logout/logout.go 77.35% <0.00%> (+0.43%) ⬆️
util/config/env.go 86.66% <0.00%> (+2.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d404f0e...5862535. Read the comment docs.

controller/cache/info.go Outdated Show resolved Hide resolved
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt August 4, 2021 16:00
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbreeze rbreeze merged commit 9c0495d into argoproj:master Aug 4, 2021
@rbreeze rbreeze deleted the https-url-fix branch August 4, 2021 16:33
alexmt pushed a commit that referenced this pull request Aug 4, 2021
Signed-off-by: Remington Breeze <remington@breeze.software>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

application external url is exposed with http instead of https
2 participants