-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add https prefix to ingress URLs if hosts field is present #6901
Conversation
Signed-off-by: Remington Breeze <remington@breeze.software>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Remington Breeze <remington@breeze.software>
Codecov Report
@@ Coverage Diff @@
## master #6901 +/- ##
==========================================
- Coverage 41.08% 41.08% -0.01%
==========================================
Files 157 157
Lines 20978 20990 +12
==========================================
+ Hits 8619 8623 +4
- Misses 11133 11139 +6
- Partials 1226 1228 +2
Continue to review full report at Codecov.
|
Signed-off-by: Remington Breeze <remington@breeze.software>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Remington Breeze <remington@breeze.software>
Fixes #6884
Signed-off-by: Remington Breeze remington@breeze.software
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: