Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove rolebinding for missing role #7510

Merged
merged 5 commits into from
May 29, 2023

Conversation

sbose78
Copy link
Contributor

@sbose78 sbose78 commented Oct 21, 2021

I can't seem to find the argocd-redis role which was referenced in the rolebinding, what am I missing ? 🤔

Signed-off-by: Shoubhik Bose <shbose@redhat.com>
Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also didnt find a place where we are using this role binding.

@pasha-codefresh
Copy link
Member

@sbose78 could you please restart checks?

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@34fathombelow 34fathombelow added the lifecycle/rotten Issue/PR had no activity for a long time and should be closed soon label Feb 24, 2023
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) May 28, 2023 00:38
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev removed the lifecycle/rotten Issue/PR had no activity for a long time and should be closed soon label May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (d49d2ae) 49.08% compared to head (3b489a3) 49.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7510      +/-   ##
==========================================
- Coverage   49.08%   49.07%   -0.01%     
==========================================
  Files         249      250       +1     
  Lines       43228    43244      +16     
==========================================
+ Hits        21217    21224       +7     
- Misses      19884    19890       +6     
- Partials     2127     2130       +3     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev merged commit dfa8065 into argoproj:master May 29, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Shoubhik Bose <shbose@redhat.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Shoubhik Bose <shbose@redhat.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants