-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove rolebinding for missing role #7510
Conversation
Signed-off-by: Shoubhik Bose <shbose@redhat.com>
9ea4464
to
e86b9fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, also didnt find a place where we are using this role binding.
@sbose78 could you please restart checks? |
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7510 +/- ##
==========================================
- Coverage 49.08% 49.07% -0.01%
==========================================
Files 249 250 +1
Lines 43228 43244 +16
==========================================
+ Hits 21217 21224 +7
- Misses 19884 19890 +6
- Partials 2127 2130 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shoubhik Bose <shbose@redhat.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Shoubhik Bose <shbose@redhat.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
I can't seem to find the
argocd-redis
role which was referenced in the rolebinding, what am I missing ? 🤔