Issue #621 - Remove resources state from application CRD #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmt
force-pushed
the
621-remove-resources-from-crd
branch
from
c323549 to
02e7694
Compare
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
=========================================
- Coverage 27% 26.5% -0.51%
=========================================
Files 41 42 +1
Lines 6359 6479 +120
=========================================
Hits 1717 1717
- Misses 4401 4522 +121
+ Partials 241 240 -1
Continue to review full report at Codecov.
|
alexmt
force-pushed
the
621-remove-resources-from-crd
branch
3 times, most recently
from
fc8bba0 to
a32588a
Compare
alexmt
changed the title
alexmt
force-pushed
the
621-remove-resources-from-crd
branch
3 times, most recently
from
f4c9768 to
ebeb6ba
Compare
alexmt
force-pushed
the
621-remove-resources-from-crd
branch
from
ebeb6ba to
99acc07
Compare
jessesuen
approved these changes
Nov 16, 2018
manifests/install.yaml
Outdated
| @@ -339,7 +350,7 @@ spec: | |||
| - "20" | |||
| - --operation-processors | |||
| - "10" | |||
| image: jessesuen/argocd-application-controller:latest | |||
| image: argoproj/argocd-application-controller:latest | |||
There was a problem hiding this comment.
It looks like I missed this image to use the new master image. Can you fix my mistake?
| Name string `json:"name,omitempty" protobuf:"bytes,4,opt,name=name"` | ||
| Status ComparisonStatus `json:"status,omitempty" protobuf:"bytes,5,opt,name=status"` | ||
| Health HealthStatus `json:"health,omitempty" protobuf:"bytes,6,opt,name=health"` | ||
| } |
There was a problem hiding this comment.
Much better data structure than what we had before. Great!
alexmt
force-pushed
the
621-remove-resources-from-crd
branch
from
99acc07 to
4c1b750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #621