fix: Retry checkbox unchecked unexpectedly; Sync up with YAML (#8682)

[keithchong]

Signed-off-by: Keith Chong kykchong@redhat.com

Fixes #8682

Granted that Pasha and the Codefresh folks are revamping the sliding panels, Remington and I chatted and agreed this should just be fixed.

See issue for two of the scenarios that are fixed. The application-retry-options pane is used in several places:
application-create-panel
application-summary
sync-panel

This change should only affect the application-create-panel. Here are the scenarios that have been tested or fixed on that page.

1. Check Retry button
2. Edit as Yaml. Cancel button.

1. Check Retry button
2. Edit as Yaml.
3. Make a change in one of the retry sub-options
4. Save

1. Check Retry button
2. Edit as Yaml.
3. Delete the lines after retry:
4. Save
   ==> Retry is checked with default values enabled. The options are required, so it's acceptable

Tested to ensure this page is working as expected:
Application Summary page

1. Go to the Application summary page for an app
2. Click on Edit
3. Check Retry button
4. Make a change to one of the retry sub-options
5. Save or Cancel
6. Edit again to verify contents

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Merging #8720 (0e2d4a3) into master (6d19813) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8720   +/-   ##
=======================================
  Coverage   42.65%   42.65%           
=======================================
  Files         183      183           
  Lines       22972    22972           
=======================================
  Hits         9799     9799           
  Misses      11790    11790           
  Partials     1383     1383           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d19813...0e2d4a3. Read the comment docs.

[alexmt]

Thanks a lot @keithchong ! LGTM