Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue preventing kustomize apps being multi-namespaced #913

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

jessesuen
Copy link
Member

No description provided.

@jessesuen jessesuen requested a review from alexmt December 9, 2018 09:15
@jessesuen jessesuen force-pushed the rm-kustomize-set-namespace branch from 095abfa to e724783 Compare December 9, 2018 09:54
@codecov-io
Copy link

codecov-io commented Dec 9, 2018

Codecov Report

Merging #913 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #913      +/-   ##
=========================================
+ Coverage   33.49%   33.5%   +<.01%     
=========================================
  Files          49      49              
  Lines        7380    7373       -7     
=========================================
- Hits         2472    2470       -2     
+ Misses       4532    4525       -7     
- Partials      376     378       +2
Impacted Files Coverage Δ
util/kustomize/kustomize.go 81.81% <ø> (+1.49%) ⬆️
reposerver/repository/repository.go 26.31% <100%> (-0.26%) ⬇️
util/webhook/webhook.go 44.94% <0%> (+3.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 457e137...e724783. Read the comment docs.

@jessesuen jessesuen merged commit 483872a into argoproj:master Dec 10, 2018
@zx8
Copy link

zx8 commented Dec 10, 2018

This seems to also affect Helm-based applications. I'm seeing the following error:

error: the namespace from the provided object "foo" does not match the
namespace "bar". You must pass '--namespace=foo' to perform this operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants