Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: docs correction on how to override azure devops URL. #9699

Conversation

brinchm
Copy link
Contributor

@brinchm brinchm commented Jun 16, 2022

Signed-off-by: Christer Brinchmann christer.brinchmann@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Christer Brinchmann <christer.brinchmann@gmail.com>
@brinchm
Copy link
Contributor Author

brinchm commented Jun 16, 2022

@crenshaw-dev Based on this discussion, I removed the env variable override, but I forgot to update the docs, which made them incorrect.

This PR contains a correction on how to override the Azure DevOps URL with the api field.

@brinchm brinchm changed the title docs correction on how to override azure devops URL. chore: docs correction on how to override azure devops URL. Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #9699 (0a399a3) into master (c478617) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9699   +/-   ##
=======================================
  Coverage   45.78%   45.78%           
=======================================
  Files         226      226           
  Lines       26713    26713           
=======================================
  Hits        12231    12231           
  Misses      12818    12818           
  Partials     1664     1664           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c478617...0a399a3. Read the comment docs.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) June 16, 2022 21:05
@crenshaw-dev crenshaw-dev merged commit 64c0847 into argoproj:master Jun 16, 2022
@brinchm brinchm deleted the chore/azuredevops-scmprovider-docscorrection branch June 17, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants