Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multiple extensions per resource group/kind #9834
feat: support multiple extensions per resource group/kind #9834
Changes from 1 commit
3c9e8d2
aba324a
c7bf97f
0a380fb
f9fb1b9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should either stream this out or add a cache. Total file of extensions will probably usually be small (<1MB), but an attacker could put memory pressure on the API server by making a bunch of requests to this endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. Working on adding caching. Sorry, answered too soon. The only difference if this endpoint fromhttp.FileServer
is that it serves multiple files instead of one which is not a big difference.We could introduce something like fsnotify but it known to cause problems in k8s (leaking file handlers). I don't think it worth it. So I would do nothing right now until we discover a real issue. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved accidentally, unresolved :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One downside to this vs.
http.FileServer
is that (I believe) that library streams the requested file from disk instead of loading it fully into memory. In the case of this new behavior, multiple files are loaded simultaneously into memory before being sent out.If we can stream the concatenated files out instead of caching them, I think that would sufficiently limit memory load on the API server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is an awesome idea! Thank you! Working on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!