docs: custom secret must be labeled #9835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell, this isn't explicitly documented anywhere (some docs mentioned this label in reference to ConfigMaps) I only figure it out by looking at the code.
crenshaw-dev
approved these changes
Jun 30, 2022
crenshaw-dev
added
the
cherry-pick/2.4
Codecov Report
@@ Coverage Diff @@
## master #9835 +/- ##
=======================================
Coverage 45.86% 45.86%
=======================================
Files 227 227
Lines 26862 26862
=======================================
Hits 12320 12320
Misses 12862 12862
Partials 1680 1680 Continue to review full report at Codecov.
|
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 1, 2022
As far as I can tell, this isn't explicitly documented anywhere (some docs mentioned this label in reference to ConfigMaps) I only figure it out by looking at the code. Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
|
Cherry-picked onto release-2.4 for 2.4.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, this isn't explicitly documented anywhere (some docs mentioned this label in reference to ConfigMaps) I only figure it out by looking at the code.