Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace deprecated ioutil in CLI code #9846

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Jul 1, 2022

The io/ioutil package has been deprecated in Go 1.16.

This is part 1/x of getting rid of io/ioutil in our codebase, replacing it by appropriate other methods from Go's standard library.

Focus: CLI code.

Signed-off-by: jannfis jann@mistrust.net

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: jannfis <jann@mistrust.net>
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #9846 (1d9d991) into master (2a3c692) will not change coverage.
The diff coverage is 13.63%.

@@           Coverage Diff           @@
##           master    #9846   +/-   ##
=======================================
  Coverage   45.75%   45.75%           
=======================================
  Files         227      227           
  Lines       26961    26961           
=======================================
  Hits        12337    12337           
  Misses      12943    12943           
  Partials     1681     1681           
Impacted Files Coverage Δ
cmd/argocd/commands/admin/app.go 30.37% <0.00%> (ø)
cmd/argocd/commands/admin/backup.go 0.00% <0.00%> (ø)
cmd/argocd/commands/admin/repo.go 0.00% <0.00%> (ø)
cmd/argocd/commands/context.go 15.18% <0.00%> (ø)
cmd/argocd/commands/gpg.go 0.00% <0.00%> (ø)
cmd/argocd/commands/repo.go 0.00% <0.00%> (ø)
cmd/argocd/commands/repocreds.go 0.00% <0.00%> (ø)
cmd/argocd/commands/admin/settings.go 68.60% <66.66%> (ø)
cmd/argocd/commands/admin/project_allowlist.go 30.95% <100.00%> (ø)
util/settings/settings.go 48.22% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a3c692...1d9d991. Read the comment docs.

@jannfis jannfis requested review from crenshaw-dev and alexmt July 1, 2022 08:02
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! @jannfis can you sort the conflicts?

@crenshaw-dev crenshaw-dev merged commit 2d6ce08 into argoproj:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants