feat: Support non-string parameters. Closes #1236 #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses #1236 |
Signed-off-by: Aalok <aalok_ahluwalia@intuit.com>
Signed-off-by: Aalok <aalok_ahluwalia@intuit.com>
Signed-off-by: Aalok <aalok_ahluwalia@intuit.com>
Signed-off-by: Aalok <aalok_ahluwalia@intuit.com>
Signed-off-by: Aalok <aalok_ahluwalia@intuit.com>
Signed-off-by: Aalok <aalok_ahluwalia@intuit.com>
Signed-off-by: Aalok <aalok_ahluwalia@intuit.com>
Signed-off-by: Aalok <aalok_ahluwalia@intuit.com>
Signed-off-by: Aalok <aalok_ahluwalia@intuit.com>
Signed-off-by: AdamKorcz <adam@adalogics.com> Signed-off-by: Aalok <aalok_ahluwalia@intuit.com>
whynowy
reviewed
Nov 22, 2022
pkg/apis/sensor/v1alpha1/types.go
Outdated
| // When true, a number, boolean, json or string parameter may be extracted. When the field is unspecified, or explicitly | ||
| // false, the behavior is to turn the extracted field into a string or json. (e.g. when set to true, the parameter | ||
| // 123 will resolve to the numerical type, but when false, or not provided, the string "123" will be resolved) | ||
| UseRawDataValue bool `json:"useRawDataValue,omitempty" protobuf:"bytes,5,opt,name=useRawDataValue"` |
There was a problem hiding this comment.
-
Please add it to the end of the struct - do not change the order of original properties.
-
If it not specified, consider it as the
string(reverting fix: payload serialization in sensor. Fixes #2272 #2273), in this case, if expecting a JSON, just set it totrue.
There was a problem hiding this comment.
👍 made the change. let me know if the wording of this comment can be improved.
There was a problem hiding this comment.
Maybe making it a bit simpler like UserRawData?
Also, it would be better to add this to the doc.
https://github.com/argoproj/argo-events/blob/master/docs/tutorials/02-parameterization.md
All the rest looks good to me! Thanks again!
…nal in documentation Signed-off-by: Aalok <aalok_ahluwalia@intuit.com>
Signed-off-by: Aalok <aalok_ahluwalia@intuit.com>
Signed-off-by: Aalok <aalok_ahluwalia@intuit.com>
whynowy
pushed a commit
that referenced
this pull request
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: