Skip to content

Commit

Permalink
feat(argo-rollouts): allow setting log config for rollouts (#2386)
Browse files Browse the repository at this point in the history
* allow setting log config for rollouts

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

* allow setting log config for rollouts

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

* allow setting log config for rollouts

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

* allow setting log config for rollouts

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

* allow setting log config for rollouts

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

* allow setting log config for rollouts

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

* allow setting log config for rollouts

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

* allow setting log config for rollouts

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

---------

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Co-authored-by: Tim Collins <45351296+tico24@users.noreply.github.com>
  • Loading branch information
DrFaust92 and tico24 authored Dec 14, 2023
1 parent 9ca3f06 commit bce77fa
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 2 deletions.
4 changes: 2 additions & 2 deletions charts/argo-rollouts/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
appVersion: v1.6.4
description: A Helm chart for Argo Rollouts
name: argo-rollouts
version: 2.32.8
version: 2.33.0
home: https://github.com/argoproj/argo-helm
icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
keywords:
Expand All @@ -19,4 +19,4 @@ annotations:
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: changed
description: Bump argo-rollouts to v1.6.4
description: Allow setting log config for rollouts
3 changes: 3 additions & 0 deletions charts/argo-rollouts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ For full list of changes please check ArtifactHub [changelog].
| controller.image.tag | string | `""` | Overrides the image tag (default is the chart appVersion) |
| controller.initContainers | list | `[]` | Init containers to add to the rollouts controller pod |
| controller.livenessProbe | object | See [values.yaml] | Configure liveness [probe] for the controller |
| controller.logging.format | string | `"text"` | Set the logging format (one of: `text`, `json`) |
| controller.logging.kloglevel | string | `"0"` | Set the klog logging level |
| controller.logging.level | string | `"info"` | Set the logging level (one of: `debug`, `info`, `warn`, `error`) |
| controller.metricProviderPlugins | object | `{}` | Configures 3rd party metric providers for controller |
| controller.metrics.enabled | bool | `false` | Deploy metrics service |
| controller.metrics.service.annotations | object | `{}` | Service annotations |
Expand Down
3 changes: 3 additions & 0 deletions charts/argo-rollouts/templates/controller/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ spec:
args:
- --healthzPort={{ .Values.controller.containerPorts.healthz }}
- --metricsport={{ .Values.controller.containerPorts.metrics }}
- "--loglevel={{ .Values.controller.logging.level }}"
- "--logformat={{ .Values.controller.logging.format }}"
- "--kloglevel={{ .Values.controller.logging.kloglevel }}"
{{- if not .Values.clusterInstall }}
- --namespaced
{{- end }}
Expand Down
7 changes: 7 additions & 0 deletions charts/argo-rollouts/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,13 @@ controller:
tolerations: []
# -- Assign custom [affinity] rules to the deployment
affinity: {}
logging:
# -- Set the logging level (one of: `debug`, `info`, `warn`, `error`)
level: info
# -- Set the klog logging level
kloglevel: "0"
# -- Set the logging format (one of: `text`, `json`)
format: "text"

# -- Assign custom [TopologySpreadConstraints] rules to the controller
## Ref: https://kubernetes.io/docs/concepts/workloads/pods/pod-topology-spread-constraints/
Expand Down

0 comments on commit bce77fa

Please sign in to comment.