Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(argo-workflows): update comment for azure artifact repository blobNameFormat #2229

Merged
merged 8 commits into from
Aug 19, 2023
Merged

chore(argo-workflows): update comment for azure artifact repository blobNameFormat #2229

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e5ef149
Update values.yaml
jsong336 Aug 18, 2023
d929ce4
added change log
jsong336 Aug 18, 2023
856619d
updated workflowtaskresults crd
jsong336 Aug 18, 2023
bd48287
bumped chart version
jsong336 Aug 18, 2023
5520217
add blobNameFormat as required
jsong336 Aug 18, 2023
fe0cd1d
fix workflowtaskresults
jsong336 Aug 18, 2023
9f97c33
updated change log
jsong336 Aug 18, 2023
c92355c
fixed change log
jsong336 Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion charts/argo-workflows/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: v3.4.10
name: argo-workflows
description: A Helm chart for Argo Workflows
type: application
version: 0.33.0
version: 0.33.1
icon: https://argoproj.github.io/argo-workflows/assets/logo.png
home: https://github.com/argoproj/argo-helm
sources:
Expand All @@ -18,3 +18,5 @@ annotations:
artifacthub.io/changes: |
- kind: added
description: add imagePullSecret for workflow sa
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsong336
Please remove old one. 🙋

- kind: updated
Copy link
Collaborator

@yu-croco yu-croco Aug 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably updated is not supported in artifacthub.io/changes , so maybe fixed ?

Ref: https://github.com/argoproj/argo-helm/blob/main/CONTRIBUTING.md#changelog

image

[updated]
FYI: kinds are shown like this.
https://artifacthub.io/packages/helm/argo/argo-cd?modal=changelog

image

description: updated azure blob to blobNameFormat
2 changes: 1 addition & 1 deletion charts/argo-workflows/templates/crds/argoproj.io_workflowtaskresults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ spec:
required:
- key
type: object
blob:
blobNameFormat:
jsong336 marked this conversation as resolved.
Show resolved Hide resolved
type: string
container:
type: string
Expand Down
2 changes: 1 addition & 1 deletion charts/argo-workflows/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,7 @@ artifactRepository:
azure: {}
# endpoint: https://mystorageaccountname.blob.core.windows.net
# container: my-container-name
# blob: path/in/container
# blobNameFormat: path/in/container
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
https://argoproj.github.io/argo-workflows/fields/
image

## accountKeySecret is a secret selector.
## It references the k8s secret named 'my-azure-storage-credentials'.
## This secret is expected to have have the key 'account-access-key',
Expand Down