Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alert rules example on values #2292

Closed
wants to merge 1 commit into from
Closed

Conversation

alileza
Copy link
Contributor

@alileza alileza commented Oct 11, 2023

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Signed-off-by: Ali Reza <alirezayahya@gmail.com>
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please handle below, items in your PR description.

I have bumped the chart version according to versioning

I have updated the chart changelog with all the changes that come with this pull request according to changelog.

My build is green (troubleshooting builds).

@mkilchhofer mkilchhofer marked this pull request as draft October 12, 2023 11:39
@yu-croco
Copy link
Collaborator

Hi @alileza , are you available to handle the requested changes?

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants