Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-cd): render some values by tpl function #2306

Closed
wants to merge 19 commits into from
Closed

feat(argo-cd): render some values by tpl function #2306

wants to merge 19 commits into from

Conversation

bkomraz1
Copy link

@bkomraz1 bkomraz1 commented Oct 21, 2023 •
edited
Loading

Some chart values should be evaluated by tpl function #2305

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@bkomraz1
render values by tpl function
d68a183 
Signed-off-by: Boris Komraz <bkomraz1@gmail.com>
@bkomraz1 bkomraz1 marked this pull request as ready for review October 21, 2023 17:14
@bkomraz1
Copy link
Author

Hi @yu-croco
Can you please review the pull request?

tico24
tico24 reviewed Oct 23, 2023
View reviewed changes
charts/argo-cd/values.yaml Outdated Show resolved Hide resolved
@bkomraz1
render values by tpl function
f553558 
Signed-off-by: Boris Komraz <bkomraz1@gmail.com>
@github-actions github-actions bot added size/L and removed size/S labels Oct 27, 2023
@bkomraz1
render values by tpl function
77bcc96 
Signed-off-by: Boris Komraz <bkomraz1@gmail.com>
@bkomraz1
render values by tpl function
fde9cf7 
Signed-off-by: Boris Komraz <bkomraz1@gmail.com>
@bkomraz1
render values by tpl function
c59ac6d 
Signed-off-by: Boris Komraz <bkomraz1@gmail.com>
@github-actions github-actions bot added size/M and removed size/L labels Oct 27, 2023
@bkomraz1
render values by tpl function
6e5f52d 
Signed-off-by: Boris Komraz <bkomraz1@gmail.com>
@bkomraz1
render values by tpl function
1ed8ae3 
Signed-off-by: Boris Komraz <bkomraz1@gmail.com>
@bkomraz1
render values by tpl function
c4bd8ca 
Signed-off-by: Boris Komraz <bkomraz1@gmail.com>
@bkomraz1
render values by tpl function
df407fa 
Signed-off-by: Boris Komraz <bkomraz1@gmail.com>
@bkomraz1
merge from main
776ea67 
Signed-off-by: Boris Komraz <bkomraz1@gmail.com>
@bkomraz1
merge from main
1200001 
Signed-off-by: Boris Komraz <bkomraz1@gmail.com>
@bkomraz1
Merge remote-tracking branch 'upbound/main' into render-values-by-tpl…
05fa3cb 
…-func
@bkomraz1
Merge remote-tracking branch 'upbound/main' into render-values-by-tpl…
c2215ba 
…-func

# Conflicts:
#	charts/argo-cd/Chart.yaml
@bkomraz1
Copy link
Author

@tico24 can you please review the pull request?

@bkomraz1 bkomraz1 requested a review from tico24 October 30, 2023 16:21
yu-croco
yu-croco reviewed Nov 1, 2023
View reviewed changes
charts/argo-cd/README.md Outdated Show resolved Hide resolved
@bkomraz1
Merge remote-tracking branch 'upbound/main' into render-values-by-tpl…
e779ad7 
…-func

Signed-off-by: Boris Komraz <bkomraz1@gmail.com>
@bkomraz1
Fix typo
932022e 
Signed-off-by: Boris Komraz <bkomraz1@gmail.com>
@bkomraz1 bkomraz1 requested a review from yu-croco November 3, 2023 11:14
@bkomraz1
Copy link
Author

bkomraz1 commented Nov 3, 2023

@yu-croco @tico24 @jmeridth @mkilchhofer @pdrastil @mbevc1
Dear reviewers, can you please help me with reviewing the pull request that was open 2 week ago?

@bkomraz1
Merge remote-tracking branch 'upbound/main' into render-values-by-tpl…
ed7f50f 
…-func

Signed-off-by: Boris Komraz <bkomraz1@gmail.com>
@bkomraz1 bkomraz1 force-pushed the render-values-by-tpl-func branch from e07256e to ed7f50f Compare November 3, 2023 12:45
@bkomraz1
Merge remote-tracking branch 'upbound/main' into render-values-by-tpl…
2648836 
…-func

# Conflicts:
#	charts/argo-cd/Chart.yaml
@bkomraz1
Merge remote-tracking branch 'upbound/main' into render-values-by-tpl…
659c4eb 
…-func

# Conflicts:
#	charts/argo-cd/Chart.yaml
#	charts/argo-cd/README.md
#	charts/argo-cd/README.md.gotmpl
@bkomraz1
Merge branch 'main' into render-values-by-tpl-func
15bd7bb
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbevc1 mbevc1 Awaiting requested review from mbevc1 mbevc1 is a code owner

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

Assignees
No one assigned
Labels
argo-cd no-pr-activity size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkomraz1 @yu-croco @tico24