fix(argo-cd): Remove namespace from cluster scope resource #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few resources I noticed had the namespace set for cluster scoped resources. Signed-off-by: Jonny Langefeld <jonny.langefeld@snowflake.com>
sfc-gh-jlangefeld
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
Signed-off-by: Jonny Langefeld <jonny.langefeld@snowflake.com>
|
Thanks for this, can you please address the PR title and the changelog? (basically the things in the tick list) |
mkilchhofer
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer (-Kilchhofer) <mkilchhofer@users.noreply.github.com>
mkilchhofer
approved these changes
Sep 23, 2024
mbevc1
approved these changes
Sep 23, 2024
rouke-broersma
referenced
this pull request
in broersma-forslund/homelab
Sep 23, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [argo-cd](https://github.com/argoproj/argo-helm) | patch | `7.6.1` -> `7.6.2` | --- ### Release Notes <details> <summary>argoproj/argo-helm (argo-cd)</summary> ### [`v7.6.2`](https://github.com/argoproj/argo-helm/releases/tag/argo-cd-7.6.2) [Compare Source](https://github.com/argoproj/argo-helm/compare/argo-cd-7.6.1...argo-cd-7.6.2) A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes. #### What's Changed - chore(deps): bump github/codeql-action from 3.26.7 to 3.26.8 in the dependencies group by [@​dependabot](https://github.com/dependabot) in [https://github.com/argoproj/argo-helm/pull/2933](https://github.com/argoproj/argo-helm/pull/2933) - fix(argo-cd): Remove namespace from cluster scope resource by [@​sfc-gh-jlangefeld](https://github.com/sfc-gh-jlangefeld) in [https://github.com/argoproj/argo-helm/pull/2833](https://github.com/argoproj/argo-helm/pull/2833) #### New Contributors - [@​sfc-gh-jlangefeld](https://github.com/sfc-gh-jlangefeld) made their first contribution in [https://github.com/argoproj/argo-helm/pull/2833](https://github.com/argoproj/argo-helm/pull/2833) **Full Changelog**: argoproj/argo-helm@argo-workflows-0.42.3...argo-cd-7.6.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/broersma-forslund/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few resources I noticed had the namespace set for cluster scoped resources.
Checklist: