Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-workflows): Avoid to create ClusterRole for cluster template when singleNamespace #2955

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

yu-croco
Copy link
Collaborator

@yu-croco yu-croco commented Oct 1, 2024

Resolves #2939

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

… when singleNamespace

Signed-off-by: yu-croco <yu.croco@gmail.com>
@yu-croco yu-croco marked this pull request as ready for review October 1, 2024 18:23
Copy link
Collaborator

@vladlosev vladlosev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yu-croco yu-croco merged commit d61432b into argoproj:main Oct 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argo Workflows in "Namespaced Mode" still creates a ClusterRole and Name Clashes With Multiple Installs
3 participants