Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-cd): fixed shard value in clusterCredentials Secret #2982

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

adisong
Copy link
Contributor

@adisong adisong commented Oct 16, 2024

Quotes shard value in clusterCredential Secret object otherwise it is parsed as number and throws

json: cannot unmarshal number into Go struct field Secret.stringData of type string

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Signed-off-by: Adrian Gaciąg <9296199+adisong@users.noreply.github.com>
@yu-croco yu-croco merged commit f0c5ccc into argoproj:main Oct 16, 2024
8 checks passed
@adisong adisong deleted the fix/shard_value branch October 16, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants