Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argocd-image-updater): update RBAC namespaced role #3073

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

fad3t
Copy link
Contributor

@fad3t fad3t commented Dec 9, 2024

This PR add permissions for the image-updater Role when createClusterRole is set to false.
It is useful for namespaced deployments, where image-updater need to be able to read and update Applications in the same namespace.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@yu-croco
Copy link
Collaborator

Hi @fad3t , thank you for your PR.
Please handle below, the one in your PR description. You can refer merged PRs if you want to know the examples.

I have updated the chart changelog with all the changes that come with this pull request according to changelog.

@fad3t fad3t force-pushed the fix-image-updater-rbac branch from 1d8c478 to 61b2ff1 Compare December 11, 2024 05:42
Signed-off-by: Frederic Mereu <frederic.mereu@gaming1.com>
@fad3t fad3t force-pushed the fix-image-updater-rbac branch from 61b2ff1 to 0d3ea0b Compare December 11, 2024 05:43
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. LGTM.

@yu-croco yu-croco enabled auto-merge (squash) December 12, 2024 10:21
@yu-croco yu-croco merged commit 21d9d3e into argoproj:main Dec 13, 2024
6 checks passed
@fad3t fad3t deleted the fix-image-updater-rbac branch December 13, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants