Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-workflows): a link in values.yaml for Kubernetes Ingress docs #3079

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix(argo-workflows): a link in values.yaml for Kubernetes Ingress docs #3079

merged 1 commit into from
Dec 16, 2024

Conversation

inamuu
Copy link
Contributor

@inamuu inamuu commented Dec 16, 2024 •
edited
Loading

I couldn’t access the link because it returned a 404 Not Found error.
Therefore, I updated the link to an existing URL.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@inamuu inamuu force-pushed the fix/refs-doc-for-ingress branch from ede0a95 to bbf1a34 Compare December 16, 2024 05:25
@inamuu inamuu changed the title Fix a link in values.yaml for Kubernetes Ingress docs fix(argo-workflows): a link in values.yaml for Kubernetes Ingress docs Dec 16, 2024
@yu-croco
Copy link
Collaborator

yu-croco commented Dec 16, 2024 •
edited
Loading

Hi @inamuu , thank you for your PR.
Please handle items in your PR description. You checked them but I am afraid you didn't handle them properly.

[ ] I have bumped the chart version according to versioning
[ ] I have updated the chart changelog with all the changes that come with this pull request according to changelog.

@inamuu inamuu force-pushed the fix/refs-doc-for-ingress branch from bbf1a34 to 9312049 Compare December 16, 2024 05:50
@inamuu
Copy link
Contributor Author

inamuu commented Dec 16, 2024

@yu-croco
Thank you for your reply.
I fixed it. Please check the commit 🙏

tico24
tico24 previously approved these changes Dec 16, 2024
View reviewed changes
yu-croco
yu-croco previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. LGTM.

@yu-croco yu-croco dismissed their stale review December 16, 2024 06:24

version bump is wrong

@inamuu
fix(argo-workflows): a link in values.yaml for Kubernetes Ingress docs
11bd138 
Signed-off-by: inamuu <8310973+inamuu@users.noreply.github.com>
@inamuu inamuu force-pushed the fix/refs-doc-for-ingress branch from 9312049 to 11bd138 Compare December 16, 2024 16:05
@inamuu inamuu requested a review from yu-croco December 16, 2024 16:07
vladlosev
vladlosev approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@vladlosev vladlosev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmeridth jmeridth merged commit f9856eb into argoproj:main Dec 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tico24 tico24 tico24 approved these changes

@vladlosev vladlosev vladlosev approved these changes

@jmeridth jmeridth jmeridth approved these changes

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

Assignees
No one assigned
Labels
argo-workflows size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@inamuu @yu-croco @jmeridth @vladlosev @tico24