Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-cd): Extend DRY support for Ingress #3081

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat(argo-cd): Extend DRY support for Ingress #3081

wants to merge 3 commits into from
+6 −6

Conversation

gyajangi1
Copy link

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@gyajangi1
Updated tpl function
702e12b 
Signed-off-by: gyajangi1 <Sandeep.Gyajangi@ge.com>
@tico24 tico24 marked this pull request as draft December 17, 2024 10:50
@gyajangi1 gyajangi1 changed the title Updated tpl function feat:Extend DRY support for Ingress Dec 17, 2024
@gyajangi1 gyajangi1 changed the title feat:Extend DRY support for Ingress fix:Extend DRY support for Ingress Dec 17, 2024
@gyajangi1 gyajangi1 changed the title fix:Extend DRY support for Ingress fix: Extend DRY support for Ingress Dec 17, 2024
@gyajangi1 gyajangi1 changed the title fix: Extend DRY support for Ingress feat: Extend DRY support for Ingress Dec 17, 2024
@gyajangi1 gyajangi1 changed the title feat: Extend DRY support for Ingress feat(argo-cd): Extend DRY support for Ingress Dec 17, 2024
Ceddaerrix
Ceddaerrix suggested changes Dec 17, 2024
View reviewed changes
charts/argo-cd/templates/argocd-server/ingress.yaml Outdated
@@ -9,7 +9,7 @@ metadata:
labels:
{{- include "argo-cd.labels" (dict "context" . "component" .Values.server.name "name" .Values.server.name) | nindent 4 }}
{{- with .Values.server.ingress.labels }}
{{- toYaml . | nindent 4 }}
{{- tpl (toYaml .) . | nindent 4 }}
Copy link

@Ceddaerrix Ceddaerrix Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tpl (toYaml .) . within the with context will fail since . here refers to the current context (i.e. .Values.server.ingress.labels) and not the root context.

To refer to the root context, you should change the tpl call to tpl (toYaml .) $

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed tpl call to tpl (toYaml .) $

@gyajangi1
Update ingress.yaml
7d5044e 
Signed-off-by: gyajangi1 <Sandeep.Gyajangi@ge.com>
@gyajangi1 gyajangi1 requested a review from Ceddaerrix December 18, 2024 07:51
@gyajangi1
reverted changes
3c18e66 
Signed-off-by: gyajangi1 <Sandeep.Gyajangi@ge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbevc1 mbevc1 Awaiting requested review from mbevc1 mbevc1 is a code owner

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

@Ceddaerrix Ceddaerrix Awaiting requested review from Ceddaerrix

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
argo-cd size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gyajangi1 @Ceddaerrix