fix(argo-cd): add functionality to en/disable argocd-ssh-known-hosts-cm #3083
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gajicdev
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
gajicdev
force-pushed
the
configurable-knownHosts
branch
3 times, most recently
from
3a0eef4 to
4b588ae
Compare
mkilchhofer
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Hi @gajicdev
thanks for your contribution 🙏 .
Only found 2 small things.
Regarding the "correct" keyword, I'd like to have feedback from other maintainers
charts/argo-cd/values.yaml
Outdated
| @@ -371,6 +371,9 @@ configs: | |||
| # SSH known hosts for Git repositories | |||
| ## Ref: https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup/#ssh-known-host-public-keys | |||
| ssh: | |||
| # -- Specifies if the argocd-ssh-known-hosts-cm configmap should be created by Helm. | |||
| enabled: true | |||
There was a problem hiding this comment.
I vote to create to align existing ones. 😀
There was a problem hiding this comment.
changed it to create
Signed-off-by: Davor Gajic <davor@nine.ch>
gajicdev
force-pushed
the
configurable-knownHosts
branch
from
4b588ae to
0c97774
Compare
yu-croco
approved these changes
Dec 20, 2024
mkilchhofer
approved these changes
Dec 21, 2024
mbevc1
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Closes #3082