Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-events): Support initContainers to controller #3098

Merged
merged 4 commits into from
Jan 4, 2025

Conversation

yu-croco
Copy link
Collaborator

@yu-croco yu-croco commented Dec 31, 2024

Resolves #3094

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Signed-off-by: yu-croco <yu.croco@gmail.com>
@yu-croco yu-croco force-pushed the add-missing-initcontainer branch from 8354764 to a27fda4 Compare December 31, 2024 12:31
@@ -108,6 +108,10 @@ spec:
{{- with .Values.controller.extraContainers }}
{{- toYaml . | nindent 6 }}
{{- end -}}
{{- with .Values.controller.initContainers }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yu-croco yu-croco marked this pull request as ready for review December 31, 2024 12:34
@yu-croco yu-croco requested review from mkilchhofer and mbevc1 January 4, 2025 05:35
@yu-croco yu-croco merged commit b594e6b into argoproj:main Jan 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart argo-events does not use controller.initContainers
3 participants