Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rollout match selector label to AnalysisRuns #2888

Closed
gnunn1 opened this issue Jul 17, 2023 · 1 comment · Fixed by #2903
Closed

Add Rollout match selector label to AnalysisRuns #2888

gnunn1 opened this issue Jul 17, 2023 · 1 comment · Fixed by #2903
Labels
analysis Related to Analysis CRD enhancement New feature or request

Comments

@gnunn1
Copy link
Contributor

gnunn1 commented Jul 17, 2023

Summary

Add the Rollout match selector to AnalysisRuns as labels

Use Cases

At the moment there is no easy to select all of the AnalysisRuns that belong to a specific rollout so if you want to review the past history with kubectl it's painful to select them. While the AnalysisRun does have the ownerReference set to the Rollout this is not selectable with a field-selector or any other mechanism AFAIK, typically some scripting would be needed to do so.

The idea here is to basically do the same thing with AnalysisRuns that already happens with ReplicaSets and Pods.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
@gnunn1 gnunn1 added the enhancement New feature or request label Jul 17, 2023
@kostis-codefresh kostis-codefresh added the analysis Related to Analysis CRD label Jul 24, 2023
@zachaller
Copy link
Collaborator

As a side note this is also possible: https://argo-rollouts.readthedocs.io/en/latest/features/analysis/#define-custom-labelsannotations-for-analysisrun

@zachaller zachaller mentioned this issue Jul 23, 2023
Merged
6 tasks
zachaller added a commit that referenced this issue Aug 10, 2023
@gnunn1 @zachaller
feat(analysis): Adds rollout Spec.Selector.MatchLabels to AnalysisRun. …
0b81ca2 
…Fixes #2888 (#2903)

* Add rollout matchLabels to analysisrun

* Add rollout matchLabels to analysisrun

Signed-off-by: Gerald Nunn <gerald.b.nunn@gmail.com>

* Update label to use template labels instead of match labels

* use ro labels

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* use ro labels

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* back to selector

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

---------

Signed-off-by: Gerald Nunn <gerald.b.nunn@gmail.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Co-authored-by: zachaller <zachaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analysis Related to Analysis CRD enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@zachaller @gnunn1 @kostis-codefresh