Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insecure option to Prometheus provider #2913

Closed
OpenGuidou opened this issue Jul 28, 2023 · 0 comments · Fixed by #2914
Closed

Add insecure option to Prometheus provider #2913

OpenGuidou opened this issue Jul 28, 2023 · 0 comments · Fixed by #2914
Labels
enhancement New feature or request

Comments

@OpenGuidou
Copy link
Contributor

Summary

Similarly to what's available in the web analysis provider, it would be useful to have the possibility to skip the TLS verification on prometheus endpoint.

Use Cases

provider:
  prometheus:
    address: https://prometheus.example.com
    insecure: true
    query: |
      sum(irate(
        istio_requests_total{reporter="source",destination_service=~"{{args.service-name}}",response_code!~"5.*"}[5m]
      )) /
      sum(irate(
        istio_requests_total{reporter="source",destination_service=~"{{args.service-name}}"}[5m]
      ))

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@OpenGuidou OpenGuidou added the enhancement New feature or request label Jul 28, 2023
zachaller added a commit that referenced this issue Aug 4, 2023
* feat: Add insecure option for Prometheus

Signed-off-by: Guillaume Doussin <guillaume.doussin@gmail.com>

* change grpc id

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

---------

Signed-off-by: Guillaume Doussin <guillaume.doussin@gmail.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Co-authored-by: zachaller <zachaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant