Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dev build can set DEV_IMAGE=true #2440

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

alexef
Copy link
Member

@alexef alexef commented Nov 29, 2022

noticed today that my DEV_IMAGE=true make image was building for production.

Signed-off-by: Alex Eftimie alex.eftimie@getyourguide.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexef alexef added the bug Something isn't working label Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 81.58% // Head: 81.58% // No change to project coverage 👍

Coverage data is based on head (920d750) compared to base (be987f3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2440   +/-   ##
=======================================
  Coverage   81.58%   81.58%           
=======================================
  Files         124      124           
  Lines       18959    18959           
=======================================
  Hits        15467    15467           
  Misses       2702     2702           
  Partials      790      790           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Go Published Test Results

1 800 tests   1 800 ✔️  2m 32s ⏱️
   102 suites         0 💤
       1 files           0

Results for commit 920d750.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

    2 files      2 suites   1h 36m 4s ⏱️
  92 tests   83 ✔️ 3 💤 6
190 runs  178 ✔️ 6 💤 6

For more details on these failures, see this check.

Results for commit 920d750.

@zachaller zachaller merged commit 3342427 into argoproj:master Nov 29, 2022
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants