-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update notifications engine to 7a06976 #3384
chore: Update notifications engine to 7a06976 #3384
Conversation
…074eeed6145085160e2fec63 Updating and fetch latest notifications-engine dependencies Signed-off-by: Andre Marcelo-Tanner <drechin@gmail.com>
…4.1-0.20240219110818-7a069766e954 Signed-off-by: Andre Marcelo-Tanner <drechin@gmail.com>
- Update go.mod: github.com/go-telegram-bot-api/telegram-bot-api/v5 => github.com/OvyFlash/telegram-bot-api/v5 v5.0.0-20240108230938-63e5c59035bf - Ref: argoproj/notifications-engine#265 - Could also be done via go replace --edit - go mod tidy also ran Signed-off-by: Andre Marcelo-Tanner <drechin@gmail.com>
Signed-off-by: Andre Marcelo-Tanner <drechin@gmail.com>
Signed-off-by: Andre Marcelo-Tanner <drechin@gmail.com>
…nd also replace secret with argocd-notifications-secret Signed-off-by: Andre Marcelo-Tanner <drechin@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3384 +/- ##
==========================================
+ Coverage 81.83% 83.00% +1.16%
==========================================
Files 135 135
Lines 20688 16873 -3815
==========================================
- Hits 16931 14005 -2926
+ Misses 2883 1996 -887
+ Partials 874 872 -2 ☔ View full report in Codecov by Sentry. |
Go Published Test Results2 130 tests 2 130 ✅ 2m 50s ⏱️ Results for commit abc378b. ♻️ This comment has been updated with latest results. |
E2E Tests Published Test Results 4 files 4 suites 3h 40m 53s ⏱️ For more details on these failures, see this check. Results for commit abc378b. ♻️ This comment has been updated with latest results. |
@@ -202,6 +202,7 @@ require ( | |||
|
|||
replace ( | |||
github.com/go-check/check => github.com/go-check/check v0.0.0-20180628173108-788fd7840127 | |||
github.com/go-telegram-bot-api/telegram-bot-api/v5 => github.com/OvyFlash/telegram-bot-api/v5 v5.0.0-20240108230938-63e5c59035bf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced in the notifications engine in this PR: argoproj/notifications-engine#265
@@ -4,7 +4,7 @@ go 1.20 | |||
|
|||
require ( | |||
github.com/antonmedv/expr v1.15.5 | |||
github.com/argoproj/notifications-engine v0.4.1-0.20231213155711-c02dc5fdb5e1 | |||
github.com/argoproj/notifications-engine v0.4.1-0.20240219110818-7a069766e954 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating to argoproj/notifications-engine@7a06976
if e := strReplaceDocFiles("argocd-notifications-cm", "argo-rollouts-notification-configmap", files); e != nil { | ||
log.Fatal(e) | ||
} | ||
if e := strReplaceDocFiles("argocd-notifications-secret", "argo-rollouts-notification-secret", files); e != nil { | ||
log.Fatal(e) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets replace these strings with the argo-rollouts-
equivalent.
- They recently got renamed to a
argocd-
prefixed string in docs: use real cm name instead of placeholder notifications-engine#264
Signed-off-by: Andre Marcelo-Tanner <drechin@gmail.com>
Signed-off-by: Andre Marcelo-Tanner <drechin@gmail.com>
|
name: <config-map-name> | ||
name: argo-rollouts-notification-configmap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generated by running make docs
These were recently renamed upstream to a argocd
specific name :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Fixes #3049
What
notifications-engine
:Updating
notifications
documentation generator to replace someargocd-
prefixed strings.Adding documentation for contributors on how to update
notifications-engine
like in this PR.Checklist
"fix(controller): Updates such and such. Fixes #1234"
.