Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added clarifications for short releases #3753

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

kostis-codefresh
Copy link
Member

Addresses some concerns about best practices as raised in #3752 and #3529

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>
docs/best-practices.md Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jul 29, 2024

Published E2E Test Results

  4 files    4 suites   3h 26m 47s ⏱️
111 tests 103 ✅  6 💤 2 ❌
446 runs  420 ✅ 24 💤 2 ❌

For more details on these failures, see this check.

Results for commit f0ac4c8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 29, 2024

Published Unit Test Results

2 174 tests   2 174 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit f0ac4c8.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.23%. Comparing base (65fc9ef) to head (f0ac4c8).
Report is 63 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3753      +/-   ##
==========================================
- Coverage   84.31%   84.23%   -0.08%     
==========================================
  Files         154      154              
  Lines       18014    18014              
==========================================
- Hits        15188    15174      -14     
- Misses       1989     1996       +7     
- Partials      837      844       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>
Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>
Copy link

@zachaller zachaller merged commit 643d684 into argoproj:master Jul 31, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants