-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): remove unused deps & resolutions
#534
chore(deps): remove unused deps & resolutions
#534
Conversation
9bc0e3c
to
4008bc4
Compare
Fixed merge conflicts with #509. There's a new warning during the install that seems to be because dependabot just merged #539 and #541 (they were created before #537 was merged), which are almost certainly not compatible 😕 . They seem to have finally passed CI because #509 removed some old deps. That does bolster the case of #537 |
This comment was marked as resolved.
This comment was marked as resolved.
eb71bea
to
f508f47
Compare
I may have figured out why that's happening, some of the ESLint deps ended up getting upgraded a few minors in the Perhaps may have been due to a bad merge conflict resolution with #509 |
- these are all completely unused in the current codebase (search codebase, no references) - installs, builds, tests, etc still work without all these - maybe some of these were used at some point in the past, but none of them are currently used Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
- `lodash` resolution is no longer needed as all deps are compatible with `lodash` `^4` - 640ede9 added it and it _may_ have been necessary for some of the `lodash` v3 deps there, but this codebase no longer has any `lodash` v3 deps - `@types/history` is already using `^4.7.8` without the resolution - 546911a added it while also upgrading the devDep; only upgrading the devDep was necessary Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
f508f47
to
9a9c86c
Compare
Originally started as a follow-up to argoproj/argo-workflows#12097 (comment) on
moment-timezone
, but there were actually much more unused deps to pruneMotivation
Deps
resolutions
lodash
resolution is no longer needed as all deps are compatible withlodash
^4
lodash
v3 deps there, but this codebase no longer has anylodash
v3 deps@types/history
is already using^4.7.8
without the resolutionModifications
moment-timezone
fromdependencies
devDependencies
resolutions
Verification
Notes to Reviewers
I actually wrote this on Jan 6th (see the commits), the same time as my other PRs, but I thought this would merge conflict with some of them, so I didn't create the PR, intending to rebase with those once they were merged. This actually seems to not conflict with #511 at all as far as I can tell, so creating the PR now, and because it's already been over a month with no review/merge 😕 EDIT: Welp, they actually conflicted with #509. I have a feeling past me predicted that and then I just forgot over the past month