chore(deps): upgrade to node v20 #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
type/dependencies
- node v14 is EoL and has been [since April 2023](https://github.com/nodejs/Release/blob/68840fae8fdaa59bf9431661238dbb86b4390829/README.md?plain=1#L7) - node v20 is the [current LTS version](https://github.com/nodejs/Release/blob/9cf9c6ed8178e88c74dfa1921a793701e1d162c4/README.md?plain=1#L8) - due to an old version of Storybook / Webpack, we have to run all Storybook scripts with `NODE_OPTIONS='--openssl-legacy-provider'` - this must be used if we use newer versions of node without upgrading Storybook + Webpack - unfortunately, upgrading Storybook is significantly easier said than done, especially since there are 3 different Storybook builds in this repo (v1, v2, and `antd`) - so put that off for now (or ever? since this repo is not maintained much anymore) - note that this is an insecure run-time configuration (which is why it was deprecated and is legacy), but since it is only used in development, it's not a significant vulnerability Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
force-pushed
the
chore-deps-upgrade-node-20
branch
from
09ed165 to
669bef4
Compare
|
Fixed merge conflicts |
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
problem/stale
isubasinghe
approved these changes
Jun 3, 2024
Adrien-D
pushed a commit
to Adrien-D/argo-ui
that referenced
this pull request
Jun 6, 2024
- node v14 is EoL and has been [since April 2023](https://github.com/nodejs/Release/blob/68840fae8fdaa59bf9431661238dbb86b4390829/README.md?plain=1#L7) - node v20 is the [current LTS version](https://github.com/nodejs/Release/blob/9cf9c6ed8178e88c74dfa1921a793701e1d162c4/README.md?plain=1#L8) - due to an old version of Storybook / Webpack, we have to run all Storybook scripts with `NODE_OPTIONS='--openssl-legacy-provider'` - this must be used if we use newer versions of node without upgrading Storybook + Webpack - unfortunately, upgrading Storybook is significantly easier said than done, especially since there are 3 different Storybook builds in this repo (v1, v2, and `antd`) - so put that off for now (or ever? since this repo is not maintained much anymore) - note that this is an insecure run-time configuration (which is why it was deprecated and is legacy), but since it is only used in development, it's not a significant vulnerability Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Adrien Delannoy <a.delannoyfr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes / Closes #432
Motivation
Modifications
update
.nvmrcto Node v20update allEDIT: that ended up being completed as part of refactor(deps): migrate from archivedactions/setup-nodeGH Actions to use the.nvmrcfor consistencytslinttoeslint#509due to an old version of Storybook / Webpack, we have to run all Storybook scripts with
NODE_OPTIONS='--openssl-legacy-provider'antd). See Update Node.js version on CI #432 (comment) noting my trials and tribulations with thatVerification
Install works, builds pass, tests pass
Future Work
--openssl-legacy-provider