Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use type export for interface reexports #552

Merged
merged 1 commit into from
May 11, 2024

Conversation

instauro
Copy link
Contributor

@instauro instauro commented May 5, 2024

Resolves the argo-ui related TS warnings described in argoproj/argo-workflows#13009

Related webpack issue webpack/webpack#7378 giving some background

Signed-off-by: instauro <instauro@proton.me>
@agilgur5 agilgur5 self-assigned this May 6, 2024
@agilgur5
Copy link

agilgur5 commented May 6, 2024

Ah right, I remember why I couldn't do this before, b/c it broke lint as I mentioned in argoproj/argo-workflows#12514, since this repo was still on legacy tslint which didn't support the import type syntax.
But I did eventually unblock that by migrating to ESLint in #509

Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI/lint+build pass now after #509. Thanks for the update!

Confirmed that CD and Rollouts are also on versions of TS that support this syntax

@agilgur5 agilgur5 merged commit 741f07c into argoproj:master May 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants