refactor: make context.tsx tree-shakeable
#573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `components/` is not tree-shakeable, so importing it makes this file also not tree-shakeable - similar to my PR upstream and for the Storybook here to use individual imports Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
crenshaw-dev
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
components/is not tree-shakeable, so importing it makes this file also not tree-shakeablextermdep argo-workflows#12158) and for the Storybook here (fix(deps-dev): downgrade all Storybook breakage from dependabot et al #567) to use individual importsModifications
Individually import
NotificationsApiandPopupApifrom their respective components instead of the non-treeshakeable components importalso fixup some style in the order of imports and whitespace