fix: Fix response type for artifact service OpenAPI and SDKs. Fixes #…

…7781 (#8332) Signed-off-by: Alex Collins <alex_collins@intuit.com>
argoproj · Apr 17, 2022 · 0a09568 · 0a09568
1 parent a3bce2a
commit 0a09568
Show file tree

Hide file tree

Showing 5 changed files with 42 additions and 38 deletions.
diff --git a/api/openapi-spec/swagger.json b/api/openapi-spec/swagger.json
@@ -4177,7 +4177,11 @@
         ],
         "responses": {
           "200": {
-            "description": "An artifact file."
+            "description": "An artifact file.",
+            "schema": {
+              "type": "string",
+              "format": "binary"
+            }
           },
           "default": {
             "description": "An unexpected error response.",
@@ -4223,7 +4227,11 @@
         ],
         "responses": {
           "200": {
-            "description": "An artifact file."
+            "description": "An artifact file.",
+            "schema": {
+              "type": "string",
+              "format": "binary"
+            }
           },
           "default": {
             "description": "An unexpected error response.",

diff --git a/pkg/apiclient/_.primary.swagger.json b/pkg/apiclient/_.primary.swagger.json
@@ -65,12 +65,9 @@
         "responses": {
           "200": {
             "description": "An artifact file.",
-            "content": {
-              "text/plain": {
-                "schema": {
-                  "type": "string"
-                }
-              }
+            "schema": {
+              "type": "string",
+              "format": "binary"
             }
           },
           "default": {
@@ -119,10 +116,9 @@
           "200": {
             "description": "An artifact file.",
             "content": {
-              "text/plain": {
-                "schema": {
-                  "type": "string"
-                }
+              "schema": {
+                "type": "string",
+                "format": "binary"
               }
             }
           },
@@ -166,10 +162,9 @@
           "200": {
             "description": "An artifact file.",
             "content": {
-              "text/plain": {
-                "schema": {
-                  "type": "string"
-                }
+              "schema": {
+                "type": "string",
+                "format": "binary"
               }
             }
           },
@@ -218,12 +213,9 @@
         "responses": {
           "200": {
             "description": "An artifact file.",
-            "content": {
-              "text/plain": {
-                "schema": {
-                  "type": "string"
-                }
-              }
+            "schema": {
+              "type": "string",
+              "format": "binary"
             }
           },
           "default": {

diff --git a/sdks/java/client/docs/ArtifactServiceApi.md b/sdks/java/client/docs/ArtifactServiceApi.md
@@ -78,7 +78,7 @@ No authorization required
 
 <a name="artifactServiceGetInputArtifactByUID"></a>
 # **artifactServiceGetInputArtifactByUID**
-> artifactServiceGetInputArtifactByUID(namespace, uid, podName, artifactName)
+> File artifactServiceGetInputArtifactByUID(namespace, uid, podName, artifactName)
 
 Get an input artifact by UID.
 
@@ -102,7 +102,8 @@ public class Example {
     String podName = "podName_example"; // String | 
     String artifactName = "artifactName_example"; // String | 
     try {
-      apiInstance.artifactServiceGetInputArtifactByUID(namespace, uid, podName, artifactName);
+      File result = apiInstance.artifactServiceGetInputArtifactByUID(namespace, uid, podName, artifactName);
+      System.out.println(result);
     } catch (ApiException e) {
       System.err.println("Exception when calling ArtifactServiceApi#artifactServiceGetInputArtifactByUID");
       System.err.println("Status code: " + e.getCode());
@@ -125,7 +126,7 @@ Name | Type | Description  | Notes
 
 ### Return type
 
-null (empty response body)
+[**File**](File.md)
 
 ### Authorization
 
@@ -144,7 +145,7 @@ No authorization required
 
 <a name="artifactServiceGetOutputArtifact"></a>
 # **artifactServiceGetOutputArtifact**
-> artifactServiceGetOutputArtifact(namespace, name, podName, artifactName)
+> File artifactServiceGetOutputArtifact(namespace, name, podName, artifactName)
 
 Get an output artifact.
 
@@ -168,7 +169,8 @@ public class Example {
     String podName = "podName_example"; // String | 
     String artifactName = "artifactName_example"; // String | 
     try {
-      apiInstance.artifactServiceGetOutputArtifact(namespace, name, podName, artifactName);
+      File result = apiInstance.artifactServiceGetOutputArtifact(namespace, name, podName, artifactName);
+      System.out.println(result);
     } catch (ApiException e) {
       System.err.println("Exception when calling ArtifactServiceApi#artifactServiceGetOutputArtifact");
       System.err.println("Status code: " + e.getCode());
@@ -191,7 +193,7 @@ Name | Type | Description  | Notes
 
 ### Return type
 
-null (empty response body)
+[**File**](File.md)
 
 ### Authorization
 

diff --git a/sdks/python/client/argo_workflows/api/artifact_service_api.py b/sdks/python/client/argo_workflows/api/artifact_service_api.py
diff --git a/sdks/python/client/docs/ArtifactServiceApi.md b/sdks/python/client/docs/ArtifactServiceApi.md