fix: improve feedback when submitting a workflow from the CLI w/o a s…

…erviceaccount specified (#7246)

Signed-off-by: Benny Cornelissen <mail@bennycornelissen.nl>

cmd/argo/commands/archive/get.go

@@ -51,7 +51,11 @@ func NewGetCommand() *cobra.Command {
 				fmt.Printf(fmtStr, "Namespace:", wf.ObjectMeta.Namespace)
 				serviceAccount := wf.Spec.ServiceAccountName
 				if serviceAccount == "" {
-					serviceAccount = "default"
+					// if serviceAccountName was not specified in a submitted Workflow, we will
+					// use the serviceAccountName provided in Workflow Defaults (if any). If that
+					// also isn't set, we will use the 'default' ServiceAccount in the namespace
+					// the workflow will run in.
+					serviceAccount = "unset (will run with the default ServiceAccount)"
 				}
 				fmt.Printf(fmtStr, "ServiceAccount:", serviceAccount)
 				fmt.Printf(fmtStr, "Status:", wf.Status.Phase)

cmd/argo/commands/get.go

@@ -120,7 +120,11 @@ func printWorkflowHelper(wf *wfv1.Workflow, getArgs getFlags) string {
 	out += fmt.Sprintf(fmtStr, "Namespace:", wf.ObjectMeta.Namespace)
 	serviceAccount := wf.Spec.ServiceAccountName
 	if serviceAccount == "" {
-		serviceAccount = "default"
+		// if serviceAccountName was not specified in a submitted Workflow, we will
+		// use the serviceAccountName provided in Workflow Defaults (if any). If that
+		// also isn't set, we will use the 'default' ServiceAccount in the namespace
+		// the workflow will run in.
+		serviceAccount = "unset (will run with the default ServiceAccount)"
 	}
 	out += fmt.Sprintf(fmtStr, "ServiceAccount:", serviceAccount)
 	out += fmt.Sprintf(fmtStr, "Status:", printer.WorkflowStatus(wf))